[Bug 1086231] Review Request: nodejs-jsonparse - Pure-js JSON streaming parser for node.js

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1086231



--- Comment #3 from Tom Hughes <tom@xxxxxxxxxx> ---
A few more issues:

* You need "BuildRequire: npm(tap)" so that %check can run

* You will also need to BuildRequire any npm modules that the tests need - try
building in mock to see if you have it right

* You should use "%nodejs_symlink_deps --check" in %check instead of setting
NODE_PATH

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]