[Bug 1084813] Review Request: gnubatch - Provides enhanced job control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1084813



--- Comment #17 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> %dir %{_datadir}/%{name}/help
> %{_datadir}/%{name}/help/
> 
> Is the %dir required here?

It isn't. The second line includes the directory *and* everything in it. The
%dir line includes only an entry for the directory, not for any of its
contents.

The real mistake, however, is two lines before that:

  %dir %{_datadir}/%{name}
  %{_datadir}/%{name}/*
  %dir %{_datadir}/%{name}/help
  %{_datadir}/%{name}/help/*

The wildcard line

  %{_datadir}/%{name}/*

also matches

  %{_datadir}/%{name}/help

which includes that directory and its files the first time.

You could replace the four lines with just

  %{_datadir}/%{name}/
or
  %{_datadir}/%{name}

to include that dir and anything below it. The trailing slash is just for
readability (to be explicit that the file entry is about a directory tree and
not a single data file or such).

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
 -> https://fedoraproject.org/wiki/Packaging:UnownedDirectories

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]