Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pgpool-II : Connection pooling/replication server for PostgreSQL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229321 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-04-12 02:19 EST ------- Several issues: 1. Missing BR's: ... checking for PQexecPrepared in -lpq... no configure: error: libpq is not installed or libpq is old error: Bad exit status from /var/tmp/rpm-tmp.37113 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.37113 (%build) => MISSING: BR: postgresql-devel 2. Package supports --disable-static => append --disable-static to %configure 3. All of the manual installs in %install are superfluous: @@ -52,11 +53,6 @@ make DESTDIR=%{buildroot} install mv %{buildroot}%{_sysconfdir}/pgpool.conf.sample %{buildroot}%{_sysconfdir}/pgpool.conf mv %{buildroot}%{_sysconfdir}/pcp.conf.sample %{buildroot}%{_sysconfdir}/pcp.conf -install -m 644 pgpool.8 %{buildroot}%{_mandir}/man8/ -install -m 644 -p pcp/pcp.h %{buildroot}%{_includedir}/ -install -m 755 pcp/.libs/libpcp.so.0.* %{buildroot}%{_libdir}/ -cp -a pcp/.libs/libpcp.so.0 %{buildroot}%{_libdir}/ -install -m 644 -p pool_type.h %{buildroot}%{_includedir}/ # nuke libtool archive and static lib rm -f %{buildroot}%{_libdir}/libpcp.{a,la} 4. Very serious compiler warnings: if gcc -DHAVE_CONFIG_H -DDEFAULT_CONFIGDIR=\"/etc\" -I. -I. -I. -Wall -Wmissing-prototypes -Wmissing-declarations -D_GNU_SOURCE -I /usr/include/pgsql -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -MT pool_process_query.o -MD -MP -MF ".deps/pool_process_query.Tpo" -c -o pool_process_query.o pool_process_query.c; \ then mv -f ".deps/pool_process_query.Tpo" ".deps/pool_process_query.Po"; else rm -f ".deps/pool_process_query.Tpo"; exit 1; fi pool_process_query.c: In function 'process_reporting': pool_process_query.c:2453: warning: call to __builtin___strncpy_chk will always overflow destination buffer pool_process_query.c:2578: warning: call to __builtin___snprintf_chk will always overflow destination buffer pool_process_query.c:2580: warning: call to __builtin___snprintf_chk will always overflow destination buffer pool_process_query.c:2583: warning: call to __builtin___snprintf_chk will always overflow destination buffer pool_process_query.c:2585: warning: call to __builtin___snprintf_chk will always overflow destination buffer pool_process_query.c:2588: warning: call to __builtin___snprintf_chk will always overflow destination buffer pool_process_query.c:2590: warning: call to __builtin___snprintf_chk will always overflow destination buffer pool_process_query.c:2593: warning: call to __builtin___snprintf_chk will always overflow destination buffer pool_process_query.c:2595: warning: call to __builtin___snprintf_chk will always overflow destination buffer -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review