https://bugzilla.redhat.com/show_bug.cgi?id=1096264 David Dick <ddick@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from David Dick <ddick@xxxxxxxx> --- Licensing is correct BuildRoot can be removed (all the EL5 tags has been cleaned up) Spec and SRPM are slightly different. Diff spec file in url and in SRPM --------------------------------- --- /home/makerpm/1096264-perl-JSON-MaybeXS/srpm/perl-JSON-MaybeXS.spec 2014-05-10 10:09:23.206049415 +1000 +++ /home/makerpm/1096264-perl-JSON-MaybeXS/srpm-unpacked/perl-JSON-MaybeXS.spec 2014-05-09 23:55:55.000000000 +1000 @@ -79,5 +79,5 @@ - Update to 1.002002 - More metadata fiddling, to remove the Cpanel::JSON::XS dependency visible - to static analyzers (the prerequisites at install time remain unchanged) + to static analyzers (the prequisites at install time remain unchanged) * Wed Apr 23 2014 Paul Howarth <paul@xxxxxxxxxxxx> - 1.002001-1 Require: Exporter should be added as the "use base qw(Exporter)" syntax is not correctly auto detected rpmlint incorrectly complains about spelling errors. # Note: this package takes the approach of adding a hard dependency on # upstream's preferred back-end, Cpanel::JSON::XS, rather than using # a virtual provides/requires arrangement so that any of the supported # back-ends could be used. This is not only much simpler and does not # involve modifications to the back-end packages, but it also makes for # consistent results as we're always using the same, most-tested # back-end. Agreed. Cpanel::JSON::XS is the preferred dependency of the author. # Test Suite (wants JSON::PP ≥ 2.27202 really but EL-6 doesn't have that) No problems as above. EL6 builds and tests fine at at http://koji.fedoraproject.org/koji/taskinfo?taskID=6833571 Package APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review