https://bugzilla.redhat.com/show_bug.cgi?id=458974 --- Comment #43 from Richard Shaw <hobbes1069@xxxxxxxxx> --- (In reply to Sandro Mani from comment #41) > Taking for review. Full review below. Main points: > > ** MUST Items: ** > [!]: Provides: bundled(gnulib) in place as required. > Note: > [x]: Package contains no bundled libraries without FPC exception. > -> gnulib ok, add this link to spec: > https://fedorahosted.org/fpc/ticket/174, see > http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries Will fix. > [!]: Package must own all directories that it creates. > -> Require: hicolor-icon-theme I used to do this but in discussion either on another review request or on the devel mailing list it was determined that RPM can handle this so is overkill to require it. > [!]: Only use %_sourcedir in very specific situations. > Note: %_sourcedir/$RPM_SOURCE_DIR is used. > See https://fedoraproject.org/wiki/Packaging:RPM_Source_Dir > See also OCE.src:183: E: use-of-RPM_SOURCE_DIR This is for copying all the icons to the right place, I'm using a bash for loop which means grabbing them directly rather than using the macros... I'm open to suggestions here. > OCE-foundation.x86_64: W: shared-lib-calls-exit > /usr/lib64/libTKernel.so.8.0.0 exit@GLIBC_2.2.5 > OCE-foundation.x86_64: W: shared-lib-calls-exit > /usr/lib64/libTKAdvTools.so.8.0.0 exit@GLIBC_2.2.5 > -> See for instance https://bugzilla.redhat.com/attachment.cgi?id=329912 Already reported upstream. Some fixed, other they think is OK due to specific use cases. https://github.com/tpaviot/oce/issues/490 > ** SHOULD Items: ** > [!]: Packages should try to preserve timestamps of original installed files. > -> Could install %SOURCEx files with -p Will fix. > [x]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in OCE- > foundation , OCE-modeling , OCE-ocaf , OCE-visualization , OCE-draw , > OCE-devel > -> Are automatic, but might be a good to make them explicit Hmm... I was letting the sonames drive the dependencies, I would rather leave it that way if that's OK. > Also: OCE-devel.x86_64: W: no-dependency-on OCE/OCE-libs/libOCE There is no OCE base package so this is expected. > OCE.src:303: W: macro-in-comment %{version} A library was dropped that I had commented out instead of removing, now gone. > > ** Extra Items: ** > [?]: Large data in /usr/share should live in a noarch subpackage if package > is > arched. > Note: Arch-ed rpms have a total of 4249600 bytes in /usr/share > -> Guess 4MB is okay Yeah, I don't really want to create another subpackage if it can be avoided. Thanks, Richard -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review