https://bugzilla.redhat.com/show_bug.cgi?id=1060841 --- Comment #9 from Richard Shaw <hobbes1069@xxxxxxxxx> --- (In reply to Richard Shaw from comment #7) > (In reply to Christopher Meng from comment #5) > > [?]: License field in the package spec file matches the actual license. > > Note: Checking patched sources after %prep for licenses. Licenses found: > > "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v2 or > > later)", > > "GPL (v3 or later)", "Unknown or generated", "*No copyright* GPL (v3 or > > later)", "LGPL (v2 or later) (with incorrect FSF address)", "GPL (v3 or > > later) (with incorrect FSF address)". 192 files have unknown license. > > Meh. I hate licenses. I'm option to suggestion on what to do with the mix of > gpl licenses. Asking the almighty google, it looks like when GPL and LGPL code is mixed, the outcome is GPL, so I think "GPLv3+" is correct. > > Also remove the slash: > > > > %{buildroot}/%{_datadir} > > Interesting, I didn't check this because I copied it directly from the GL.. > > https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file- > install_usage Fixed. > > 2. It seems that a dead upstream library xmlrpcpp is bundled, in spite of > > its dead upstream attribution is immutable, I still deem that you should > > request an exception? Your idea is welcome. > > Well that's great... I'll ask upstream. Same as the other review, doesn't seem to be an issue: https://lists.fedoraproject.org/pipermail/devel/2014-May/199059.html > > 3. Why upstream bundles gettext header? Can you confirm with upstream? Ok, gettext seems to put the header in /usr/share so it can't really be included by anything... I guess it needs it. > > 4. Ask upstream to add license header. I've asked and he has begun work but shouldn't be a blocker... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review