[Bug 1093407] Review Request: vdr-epg-daemon - A daemon to download EPG data from the internet and manage it in a mysql database

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1093407



--- Comment #10 from Antonio Trande <anto.trande@xxxxxxxxx> ---
(In reply to MartinKG from comment #9)
> - added fedora optflags to Make.config

There are still some problems. This is a rawhide scratch build of your latest
package: http://koji.fedoraproject.org/koji/taskinfo?taskID=6814402

Optimization flags are not respected and the arm builds fail.

Your patch is

 CFLAGS += -fPIC -Wreturn-type -Wformat -pedantic -Wunused-variable
-Wunused-label \
           -Wunused-value -Wunused-function \
-          -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
+          -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 \
+          $(OPTFLAGS) $(shell mysql_config --include)


and these are optflags on a Fedora 64bit

$ rpm --eval %{optflags}
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64
-mtune=generic

1. '-Wall' option enables all the warnings about constructions (see
http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html) including all W*
already defined on upstream source.

2. There is a DEBUG mode definition with own cflags, always activated. 

3. Also, ../epglv contains an own Makefile that must be edited separately.

These three points condition the compilation. I changed your patch and the
.spec file in order to impose our optimization flags. 

Then,
epglv README is missing, I added it; I prefer to use 'cp -p' rather than 'mv'
command.

See the files attached.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]