Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libx86 - libx86 library from X https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236041 jkeating@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Flag| |fedora-review?, | |needinfo?(pjones@xxxxxxxxxx) ------- Additional Comments From jkeating@xxxxxxxxxx 2007-04-11 13:51 EST ------- Cosmetic, but any reason for BuildPreReq instead of just BuildReq? Also lame, but since our RPM can't do it itself yet, buildroot value MUST be below %{_tmppath}/ and MUST contain at least %{name}, %{version} and %{release}. See http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 Source tag should be a URL to the upstream tarball if possible: http://fedoraproject.org/wiki/Packaging/SourceURL (somewhat cosmetic, but helpful too) Another cosmetic thing, summary isn't capitalized, but since the first word is the name of the software, and that name is 'libx86' this is ignorable. Package currently doesn't build for rawhide x86_64. The build on i386 had a couple interesting rpmlint issues: E: libx86 shlib-with-non-pic-code /usr/lib/libx86.so.1 shlib-with-non-pic-code : The listed shared libraries contain object code that was compiled without -fPIC. All object code in shared libraries should be recompiled separately from the static libraries with the -fPIC option. Another common mistake that causes this problem is linking with ``gcc -Wl,-shared'' instead of ``gcc -shared''. W: libx86-devel spurious-executable-perm /usr/include/libx86.h No reason why that should be executable, but it's just a warning. x86_64 build issue: make LIBRARY=static static make[1]: Entering directory `/builddir/build/BUILD/libx86-0.99' cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -c -o x86-common.o x86-common.c x86-common.c: In function 'get_int_seg': x86-common.c:193: warning: cast to pointer from integer of different size x86-common.c: In function 'get_int_off': x86-common.c:200: warning: cast to pointer from integer of different size cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -c -o lrmi.o lrmi.c lrmi.c:83: error: field 'vm' has incomplete type Cascade from there. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review