[Bug 1093987] Review Request: python3-opengl - OpenGL bindings for Python3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1093987

Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamielinux@xxxxxxxxxxxxxxxx
                   |                            |g
             Blocks|                            |177841 (FE-NEEDSPONSOR)



--- Comment #3 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> ---
I've added "Blocks: FE-NEEDSPONSOR" as you need a sponsor.

Have you reached out to the PyOpenGL maintainers to see if they plan to build a
python3 subpackage? Since the python2 and python3 versions of PyOpenGL are
build from the same source tarball, it would make sense for both sets of
packages to be built from the same SRPM. There is more advice about this on the
Python Packaging Guidelines.

The official packaging Guidelines to browse for information:
https://fedoraproject.org/wiki/Packaging:Guidelines
https://fedoraproject.org/wiki/Packaging:Python


Issues:
=======

You can run rpmlint on your SRPM to see outstanding issues:

$ rpmlint python3-opengl-3.0.2-1.1.src.rpm 
python3-opengl.src: W: non-standard-group Development/Libraries/Python
python3-opengl.src: W: invalid-license BSD-3-Clause
python3-opengl.src:42: W: macro-in-comment %{py_requires}
python3-opengl.src:47: W: macro-in-comment %else
python3-opengl.src:49: W: macro-in-comment %endif
1 packages and 0 specfiles checked; 0 errors, 5 warnings.


1) non-standard-group

Use a valid group from /usr/share/doc/rpm/GROUPS


2) invalid-license

You should use the appropriate License tag from the following list:
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses


3) macro-in-comment

$ rpmlint -I macro-in-comment
macro-in-comment:
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

I also see some opensuse macros that don't need to be there.


4) Python Packaging Guidelines

We have a great page on the guidelines for python packages. Please use the
appropriate macros:
https://fedoraproject.org/wiki/Packaging:Python


5) I assume you don't plan to build this for EL6, so please remove any
redundant macros:

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean


6) Please use an appropriate changelog format.

https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs


7) The PyOpenGL package has the Tk widget support put into a subpackage. Have
you considered the same?


8) Consider using DistTag in the Release tag:

https://fedoraproject.org/wiki/Packaging:DistTag#.25.7Bdist.7D_in_the_Release:_field


9) Why does the Release tag start at 1.1? Probably should just be 1.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]