[Bug 1071163] Review Request: moarvm - Short for "Metamodel On A Runtime", MoarVM is a virtual machine as a backend for NQP and then Rakudo Perl 6 at the top.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1071163



--- Comment #13 from Christopher Meng <i@xxxxxxxx> ---
1. Why O3 still? (CFLAGS="$RPM_OPT_FLAGS -fPIC -O3")

2. I strongly suggest that hack the env parameters before configure or use
configure to set the flags(if possible, I can see --optimize=3 which can be
modified, not sure about others) so we can see these parameters in the welcome
message. As far as we can see from the build.log, these options are still kept
as-is:

        make: make
     compile: gcc  -O3 -DNDEBUG  -D_REENTRANT -D_FILE_OFFSET_BITS=64 -fPIC
        link: gcc  -O3 -DNDEBUG -Wl,-rpath,$(PREFIX)/lib
        libs: -luv -lsha -lreadline -lm -lpthread -lrt -ldl -ltommath

And if you really ask me to see if it really works or not, I'm afraid I can't
as I can only see these:

compiling xxx...

linking xxx...

So I can't tell you whether the debuginfo package are generated for our needs.

3. %ifarch x86_64

Does this package support ppc64? If so you should no use ifarch to judge lib or
lib64, but use sth like %{_lib} != lib.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]