[Bug 970956] Review Request: clens - A convenience library to aid in porting code from OpenBSD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=970956



--- Comment #19 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> ---
1) For what that trick:
cat << EOF > configure
#!/bin/bash
EOF
chmod +x configure
%configure
?

Just drop that lines - it looks like a garbage.

2) Some files under BSD (2 or 3 clause) and some under ISC. Why you set ISC as
license field for package? I think it should be BSD and ISC.
3) Shouldn't be it called libclens instead clens?
4) Honestly I've first time review static library. Be aware what according to
guideline
https://fedoraproject.org/wiki/Packaging:Guidelines#Statically_Linking_Executables
you must need citing "The packager must provide rationale for linking
statically, including precedences where available, to FESCO for approval."
So, as it packaged as dependency to mg (bz#1010897) i strongly encourage you
firstly request that exception to do not make useless effort.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]