https://bugzilla.redhat.com/show_bug.cgi?id=1093407 --- Comment #3 from MartinKG <mgansser@xxxxxxxx> --- (In reply to Antonio Trande from comment #1) > - Please, use macro and not hardlinks: > > sed -i \ > -e 's|PREFIX = /usr/local|PREFIX = %{_prefix}|' \ > -e 's|PLGDEST = $(DESTDIR)$(PREFIX)/lib/epgd/plugins|PLGDEST = > $(DESTDIR)%{_libdir}/epgd|' \ > Make.config done > - The > 'vdr-epg-daemon-eb7f12a6c44b3615b5ecf6b2c4b7bb354ecc5d87/tools/curlfuncs. > cpp' file is > released with a BSD(3clause) license and it's involved in the compilation. done > (http://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#Mixed_Source_Licensing_Scenario) > > Also, COPYING file reports a GPLv2 license. > Fix the License tag. fixed > - %{_libdir}/epgd is not owned by the package done > - %{_libdir}/mysql/plugin is owned by 'mariadb-server'. It's a Requires > package. added, done > - Why 'Requires: vdr' is not explicit like your others VDR plugins ? vdr-epg-daemon can act as a standalon daemon. I admit here a comment by ville ville.skytta about the dependency to vdr: Also, are you sure that this package really depends on vdr(abi)%{_isa} = %{vdr_apiversion}, or if a simple "Requires: vdr" would be enough? It doesn't seem to be a vdr plugin so I'd imagine it's not that strictly wired to VDR's API/ABI version. > - Please, leave a comment about upstream patch. > done > - Optimization flags are not honored. > (http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags) > if i add the optflags as below, %build # make %{?_smp_mflags} all make CFLAGS="%{optflags} -fPIC" CXXFLAGS="%{optflags} -fPIC" %{?_smp_mflags} all the compilation fails with the error message: + cd vdr-epg-daemon-eb7f12a6c44b3615b5ecf6b2c4b7bb354ecc5d87 + make 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fPIC' 'CXXFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fPIC' -j3 g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fPIC -c -D_GNU_SOURCE -DTARGET='"epgd"' -DPLGDIR='"/usr/lib64/epgd"' -DUSEMD5 -DUSEUUID -DUSELIBXML -DUSELIBARCHIVE -I/usr/include/libxml2 -I/usr/include/libxml2 -o lib/db.o lib/db.c lib/db.c:9:20: fatal error: errmsg.h: No such file or directory #include <errmsg.h> ^ compilation terminated. have you any idea how to fix this ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review