Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: LabPlot - Data Analysis and Visualization https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221027 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-04-11 10:48 EST ------- Well, actually I have not read the previous discussion in this bug, so some of them I write below may be already addressed previously... For 1.5.1.5-4: A. Spec file description * SourceURL - Please check http://fedoraproject.org/wiki/Packaging/SourceURL * Dependency for main package - Usually dependency for main package should be release number specific. * Conditional dependency -------------------------------------------------------- # Use of --enable-final: The gsl version 1.6 has a bug which may cause problems. -------------------------------------------------------- - While I don't know what --enable-final does, however rawhide gsl is gsl-1.8-3.fc7. Please check if this feature can be enabled. By the way, configure checkes gsl version....... -------------------------------------------------------- gsl : yes gsl-devel : yes gsl >= 1.4 : yes gsl >= 1.6 : yes gsl >= 1.7 : yes -------------------------------------------------------- B. File entry * French documentation files - While you split br, de, ... language documentation files into seperate subpackages, why don't you split French documents? * Doc rpms dependency - Currently, this is corrupted. Also for _installed_ rpms, I get the following rpmlint. -------------------------------------------------------- [tasaka1@localhost ~]$ rpmlint LabPlot-doc-it W: LabPlot-doc-it dangling-relative-symlink /usr/share/doc/HTML/it/LabPlot/small_pics ../../en/LabPlot/small_pics [tasaka1@localhost ~]$ rpm -qa | grep LabPlot | sort LabPlot-1.5.1.5-4.fc7 LabPlot-devel-1.5.1.5-4.fc7 LabPlot-doc-it-1.5.1.5-4.fc7 -------------------------------------------------------- B. rpmlint * Attached (currently only 3 rpms above are installed). Summary: - There are many files withWindows style end-of-line encoding. NOTE: there are no complaint about this on main package, however allmost all files under /usr/share/apps/LabPlot/colormaps in main package also have Windows-like end-of-file encodings so they should be fixed. - Symlinks are corrupted (see above) - For undefined-non-weak-symbol: * First of all, what is the use of -devel package? There are no header files in -devel package, so generally other applications has no way to know how to link against libLabPlot.so or libLabPlotcephes.so. Is this -devel package really useful? * If the libraries libLabPlot.so or libLabPlotcephes.so are supposed to be linked from other packages, then these undefined-non-weak-symbols are the BLOCKER for this review request because leaving these symbols leads linkage for these libraries to failure. C. File check * Non-UTF8 documentation - Some of the documents installed are not encoded in UTF-8. -------------------------------------------------------- /usr/share/doc/LabPlot-1.5.1.5/BUGS: ISO-8859 English text /usr/share/doc/LabPlot-1.5.1.5/ChangeLog: ISO-8859 Java program text /usr/share/doc/LabPlot-1.5.1.5/TODO: ISO-8859 English text /usr/share/doc/LabPlot-1.5.1.5/WISHLIST: ISO-8859 English text -------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review