[Bug 1091636] Review Request: utf8cpp - A simple, portable and lightweight library for handling UTF-8 encoded strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1091636

Orion Poplawski <orion@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+



--- Comment #7 from Orion Poplawski <orion@xxxxxxxxxxxxx> ---
(In reply to Jamie Nguyen from comment #6)
> (In reply to Orion Poplawski from comment #5)
> > - I would suggest doing:
> > 
> > %files devel
> > %doc doc/*
> > 
> > and removing the current %files section.  Drop the Requires on the base
> > package (which does not exist then).
> 
> Makes sense.

I really would do:

%doc doc/*

otherwise you get:

/usr/share/doc/utf8cpp-devel/doc/ReleaseNotes

(double "doc")

> > - Not a blocker, but have you pinged upstream to add a separate license file?
> 
> I can't find any email address for the author either in the source files or
> on the sourceforge page. The sourceforge bug tracker also doesn't let you
> create any bugs. Some other users have mentioned on the sourceforge wiki
> page via comments, but I'm not sure the author has noticed.
> 
> I've sent a message to the author via the sourceforge messaging system.
> Hopefully the author receives it.

Great.

Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]