https://bugzilla.redhat.com/show_bug.cgi?id=1089770 --- Comment #4 from NIWA Hideyuki <niwa.hideyuki@xxxxxxxxxxxxxx> --- Hi, Thank you very much. I corrected them as follows. - > SPEC: > > 1. %define name lxcf > %define release 2 > %define version 0.5 > > No please don't do that. It's just a waste of time, please use tags directly. > I deleted them. > 2. Prefix: %{_prefix} > Group: Applications/Emulators > > Remove them, no need to keep them now. > I deleted them too. > 3. In %build: > > make clean > > Why? > I deleted it. It was unnecessary. > 4. Since this package doesn't use configure, you should ensure that cflags(%{optflags}) and ldflags(%{__global_ldflags}) are set properly, currently I think it's not build correctly(conform to the Fedora guidelines). > The following were put in "%build". CFLAGS=$RPM_OPT_FLAGS ; export CFLAGS LDFLAGS=$RPM_OPT_FLAGS ; export LDFLAGS > 5. parallel build > > https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make > The following were put in "%build". make %{?_smp_mflags} > 6. %defattr(-,root,root) > > Remove it. > Yes, it deleted it. > 7. Try: > > rpm -E %{_sbindir} > rpm -E %{_mandir} > I executed them. $ rpm -E %{_sbindir} /usr/sbin $ rpm -E %{_mandir} /usr/share/man Path of "%files" was corrected as follows. %{_sbindir}/lxcf %{_mandir}/man1/lxcf.1.gz > 8. %config(noreplace) %{_sysconfdir}/lxcf/lxcf.conf > > Unowned directory: > > %{_sysconfdir}/lxcf/ > > https://fedoraproject.org/wiki/Packaging:UnownedDirectories > I corrected it as follows. %config(noreplace) %{_sysconfdir}/lxcf/ > 9. %{_datadir}/doc/lxcf-%{version}/README > %{_datadir}/doc/lxcf-%{version}/COPYING > %{_datadir}/doc/lxcf-%{version}/ChangeLog > %{_datadir}/doc/lxcf-%{version}/AUTHORS > %{_datadir}/doc/lxcf-%{version}/example/README > %{_datadir}/doc/lxcf-%{version}/example/HA10 > %{_datadir}/doc/lxcf-%{version}/example/ops-script > > Since Fedora 20 the docdir is unversioned, please change. > I corrected it as follows. %doc README COPYING ChangeLog AUTHORS %doc example/README example/HA10 example/ops-script > 10. Bad scriptlet syntax: > > https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd > I corrected it as follows. %preun %systemd_preun lxcf.service %systemd_preun lxcf-sched.service %post mkdir -p %{_var}/log/lxcf/ pkill virt-manager %{_libdir}/lxcf/lxcf-init %systemd_post lxcf.service %systemd_post lxcf-sched.service /usr/bin/systemctl restart libvirtd.service %postun %systemd_postun > ------------------------------- > If you want to step furthur, you should follow > > https://fedoraproject.org/wiki/Join_the_package_collection_maintainers > > step by step. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review