https://bugzilla.redhat.com/show_bug.cgi?id=1065539 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrunge@xxxxxxxxxx --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> --- Continuing on from where I prematurely cut things off in comment 3: (In reply to David King from comment #1) > The Perl packaging guidelines seem to require a particular style of > Requires, so I suppose that should be added to the -perl subpackage: > > https://fedoraproject.org/wiki/Packaging:Perl#Perl_Requires_and_Provides I have added a Requires on perl(:MODULE_COMPAT_%{perl_version}) to the -perl subpackage. Was that all you had in mind? I don't see anything else at that URL that this package needs, I think. > Where chmod is used to change permissions, it updates the timestamp too, so > you should try to preserve timestamps (maybe with "touch -r", although there > might be a better way). Actually, no, it doesn't. It does update the ctime, but that won't match anyway. However, chmod does not change the mtime, which is the one we're worried about. Try it. New URLs: Spec URL: http://jjames.fedorapeople.org/subunit/subunit.spec SRPM URL: http://jjames.fedorapeople.org/subunit/subunit-0.0.18-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review