https://bugzilla.redhat.com/show_bug.cgi?id=1079499 --- Comment #6 from Michal Schmidt <mschmidt@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #5) > 1. /builddir/build/BUILD/sockperf-2.5.241/config/aux/missing: Unknown > `--is-lightweight' option > Try `/builddir/build/BUILD/sockperf-2.5.241/config/aux/missing --help' for > more information > configure: WARNING: 'missing' script is too old or missing > > Ask upstream to regenerate files. I run autoreconf in %prep, but the files in config/aux were not regenerated. Fixed now by calling it with '-f'. > 2. Same for the doxygen files as #1. I haven't talked about this with them yet, but yes, it is something to improve in upstream. > 3. g++ -DHAVE_CONFIG_H -I. -I.. -I. -O2 -g -pipe -Wall > -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions > -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches > -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -Werror -Wall > --param inline-unit-growth=200 -D__LINUX__ -DVERSION=2.5.241 -O3 -DNDEBUG > -g -O3 -c -o aopt.o aopt.cpp > > O3 and NDEBUG are unacceptable. You need to add a new patch. According to the packaging guidelies, using higher optimization levels would be acceptable if I could demonstrate significant speedup. Upstream may have had reasons for using these settings, but I do not have the data to show the benefit, so I adjusted patch 0001 to remove the '-O3' and '--param inline-unit-growth=200'. I disagree about '-DNDEBUG'. All it does is define the NDEBUG macro so that assert() calls are compiled into no code. That's a legitimate upstream's choice to make. New update: Spec URL: http://michich.fedorapeople.org/sockperf/sockperf.spec SRPM URL: http://michich.fedorapeople.org/sockperf/sockperf-2.5.241-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review