[Bug 1069243] Review Request: ccaudio2 - C++ class framework for telephonic audio applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1069243

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #9 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
One serious (MUSTFIX) issue:

# rpmlint ccaudio2-bin-2.1.1-2.fc21.x86_64.rpm
...
ccaudio2-bin.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/audiotool
['/usr/lib64']
ccaudio2-bin.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/tonetool
['/usr/lib64']
...


A minor issue and remark directed at upstream (presumably you, David ;) )

ccaudio2-config contains this:
...
if [ "`ldd /bin/sh | grep lib64`" = "" ]
then
    libdir=${exec_prefix}/lib
else
    libdir=${exec_prefix}/lib64
fi
...

A common approach to circumvent such clumsy hacks is to to call pkg-config from
inside of such *config scripts and to let them return the values pkg-config
returns.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]