[Bug 1089962] Review Request: radeontop - View GPU utilization off AMD/ATI Radeon devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1089962



--- Comment #2 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> %global gitversion .git%{commitdate}.%{shortcommit}
> Release:    1%{?gitversion}%{?dist}

%gitversion is somewhat in the wrong order:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
https://fedoraproject.org/wiki/Packaging:SourceURL#Github


> Group:      System Environment/Libraries

It's not a library. And the Group tag is optional nowadays:
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
/usr/share/doc/rpm/GROUPS


> BuildRequires: ncurses-devel
> BuildRequires: libpciaccess-devel

Relevant these days:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_based_on_pkg-config


> %build
> # configure doesn't exist, but we need the exported CFLAGS and friends
> %configure || :

You ought to compile in %build not in %install.


> %{_mandir}/man1/radeontop.1.gz

So far the manual pages are gzipped on-the-fly, but if you replace the ".gz"
with "*" the packaging would allow for changed/disabled compression if man
pages:

  %{_mandir}/man1/radeontop.1*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]