https://bugzilla.redhat.com/show_bug.cgi?id=1069243 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #6 from Christopher Meng <cickumqt@xxxxxxxxx> --- Unless you are going to support RHEL5, please drop below: 1. BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root 2. %{__rm} -rf %{buildroot} 3. Whole %clean section 4.%defattr(-,root,root,-) ------------ Requires: %{name} = %{version}-%{release} Please use: Requires: %{name}%{?_isa} = %{version}-%{release} ------------ Drop this in -devel: Requires: pkgconfig ------------ For simple command like make, rm, sed, chmod and so on you don't need to use macro: %{__make} --> make %{__chmod} --> chmod ------------ In -devel again: Requires: ucommon-devel --> Requires: ucommon-devel%{?_isa} Requires: %{name}-bin = %{version}-%{release} --> Requires: %{name}-bin = %{version}-%{release}%{?_isa} Requires: ucommon-devel >= 6.0.0 --> Requires: ucommon-devel%{?_isa} >= 6.0.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review