https://bugzilla.redhat.com/show_bug.cgi?id=1090501 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |cickumqt@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |cickumqt@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. -devel: Requires: %{name} = %{version}-%{release} --> Requires: %{name}%{?_isa} = %{version}-%{release} Drop Requires: pkgconfig 2. %{_docdir}/getdns/AUTHORS %{_docdir}/getdns/COPYING %{_docdir}/getdns/ChangeLog %{_docdir}/getdns/INSTALL %{_docdir}/getdns/LICENSE %{_docdir}/getdns/NEWS %{_docdir}/getdns/README.md %{_docdir}/getdns/spec/getdns-0.5.tgz %{_docdir}/getdns/spec/index.html 1) Remove %{_docdir}/getdns/INSTALL Please. 2) You shoud use %doc to mark them as docs. IMO some of them belong to main package, some are in -devel. %{_docdir}/getdns/AUTHORS %{_docdir}/getdns/COPYING %{_docdir}/getdns/ChangeLog %{_docdir}/getdns/LICENSE %{_docdir}/getdns/NEWS %{_docdir}/getdns/README.md 3) manpages use "*" at the end. 4) You forgot to own %{_includedir}/getdns/ 5) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review