https://bugzilla.redhat.com/show_bug.cgi?id=1065490 --- Comment #13 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- (In reply to Josef Stribny from comment #12) > Thanks for the valuable comments, I will go through them and fix the spec. > It's my first Perl package so I want to make it right. > > I have one question: > > > * MUSTFIX: Missing BRs: > > perl(Exporter) > > perl(XSLoader) > > perl(strict) > > There are no tests and the module is not run during build ... which is bad enough. > so I don't believe > they are required. You have a point and I have to row back (half) The point in duplicating R:'s to BRs is to detect future run-time-dependency breakages at build-time. In this case, perl(Exporter) and perl(XSLoader) are indirect dependencies, which are indirectly being pulled by building *.xs->*.o compilation and indirectly provided through the *.xs->*.o compilation infrastructure. I.e. if perl(Exporter)/perl(XSLoader) are missing at buildtime the package would fail running a test-suite, if these where removed from the run-time environment, installation would fail. As this package doesn't run a test-suite, BR: perl(Exporter)/perl(XSLoader) can be ignored in this case. perl(strict) is a bit different: It is a direct dependency of SSolv-0.01-git1e18c32/BSSolv.pm:3:use strict; I.e. it is required to be BR:'ed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review