https://bugzilla.redhat.com/show_bug.cgi?id=1065490 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review? --- Comment #10 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to Ralf Corsepius from comment #9) > This package is far from being clean and should never have been approved. > > * MUSTFIX: Missing BRs: > perl(Exporter) > perl(XSLoader) > perl(strict) Requires -------- perl-BSSolv (rpmlib, GLIBC filtered): libc.so.6 liblzma.so.5 libperl.so.5.18 libsolv.so.0 libsolv.so.0(SOLV_1.0) libsolvext.so.0 libsolvext.so.0(SOLV_1.0) libz.so.1 perl(:MODULE_COMPAT_5.18.2) perl(Exporter) perl(XSLoader) perl(strict) rtld(GNU_HASH) > * MUSTFIX: Wrong License > The spec file tells License: BSD > The README inside of the tarball tells "Same as Perl" == GPL or Artistic My bad, looks like they haven't added any license header. > * Superflous BR: cmake > The package does not seem to use cmake anywhere. > > * Superflous BR: rpm-devel > I do not see any dependency on anything from rpm-devel These 2 above are superflous, please remove. > * MUSTFIX: Missing BR: libsolv-devel > The package links against libsolv.so and libsolvext.so I think it had been added. > * MUSTFIX: Missing BR: perl-devel > The package links against libperl.so I can't see any regarding perl-devel, all except a note: https://fedoraproject.org/wiki/Packaging:Perl#Perl_Requires_and_Provides "Do not explicitly buildrequire "perl-devel" Explicitly requiring perl-devel, even when wrapped in a conditional construct, is strongly discouraged, and is generally considered a blocker at review and a packaging bug. Instead, see the next section on requiring core modules -- making sure that these core modules are BR'ed when used will pull in the correct development perl packages." I'd like to see some details here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review