https://bugzilla.redhat.com/show_bug.cgi?id=1057991 --- Comment #21 from Kenjiro Nakayama <knakayam@xxxxxxxxxx> --- Updated Updated Spec URL: http://kenjiro.fedorapeople.org/pkgreview/the_silver_searcher/the_silver_searcher.spec Updated SRPM URL: http://kenjiro.fedorapeople.org/pkgreview/the_silver_searcher/the_silver_searcher-0.21.0-1.fc20.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6767434 > You've removed too many things in the spec. The %checkout macro wasn't needed, but the %commit and %shortcommit are needed when you get the tarball from github. This part was fine. Added %commit and %shortcommit. > Also you've removed the file `%{bashcompdir}/ag` instead of the file `/usr/share/the_silver_searcher/completions/ag.bashcomp.sh`. Added "rm -f $RPM_BUILD_ROOT%{_datadir}/the_silver_searcher/completions/ag.bashcomp.sh" > Just checked, fedora-review still tells me that the tarball in your srpm doesn't match the one from github. I fixed. I think OK (and my fedora-review does not say error). Could you please check it again? Thanks, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review