https://bugzilla.redhat.com/show_bug.cgi?id=1079751 --- Comment #8 from David Dick <ddick@xxxxxxxx> --- Hi Sven, Yes, the BRs are required. Otherwise your packages will be more prone to breaking because of changes in other packages (such as packages being taken out of the default build environment), and it'll be harder to check if your package is going to be affected by a change. You can fix the utf8 warning by applying the attached patch. First include the line Patch1: date_calc_credits_utf8.patch and follow the line %setup -q -n Date-Calc-XS-%{version} with %patch1 -p1 The incorrect-fsf-address can be addressed by filing a rt.cpan.org bug against Date-Calc-XS. The rpmlint issues i was referring to come from the following package $ rpm -q rpmlint -i Name : rpmlint Version : 1.5 Release : 8.fc20 Architecture: noarch Install Date: Wed 19 Feb 2014 09:19:27 PM EST Group : Development/Tools Size : 1225796 License : GPLv2 Signature : RSA/SHA256, Tue 11 Feb 2014 01:17:08 PM EST, Key ID 2eb161fa246110c1 Source RPM : rpmlint-1.5-8.fc20.src.rpm Build Date : Tue 11 Feb 2014 08:10:57 AM EST Build Host : arm02-builder06.arm.fedoraproject.org Relocations : (not relocatable) Packager : Fedora Project Vendor : Fedora Project URL : http://sourceforge.net/projects/rpmlint/ Summary : Tool for checking common errors in RPM packages Description : rpmlint is a tool for checking common errors in RPM packages. Binary and source packages as well as spec files can be checked. $ rpmlint rpmbuild/RPMS/x86_64/perl-Date-Calc-XS-6.3-3.fc20.x86_64.rpm perl-Date-Calc-XS.x86_64: W: file-not-utf8 /usr/share/doc/perl-Date-Calc-XS/CREDITS.txt perl-Date-Calc-XS.x86_64: E: incorrect-fsf-address /usr/share/doc/perl-Date-Calc-XS/license/GNU_GPL.txt perl-Date-Calc-XS.x86_64: E: zero-length /usr/lib64/perl5/vendor_perl/auto/Date/Calc/XS/XS.bs perl-Date-Calc-XS.x86_64: E: incorrect-fsf-address /usr/share/doc/perl-Date-Calc-XS/license/GNU_LGPL.txt 1 packages and 0 specfiles checked; 3 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review