[Bug 1089949] Review Request: perl-Sort-Maker - Simple way to make efficient sort subs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1089949

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |rc040203@xxxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
Similarly as with perl-DB_File-Lock:

* MUSTFIX: Missing BRs:

+BuildRequires:  perl(base)
+BuildRequires:  perl(Benchmark)
+BuildRequires:  perl(Data::Dumper)
+BuildRequires:  perl(Exporter)
 BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(lib)
+BuildRequires:  perl(List::Util)
+BuildRequires:  perl(strict)
 BuildRequires:  perl(Test::More)
+BuildRequires:  perl(vars)
+BuildRequires:  perl(warnings)

I am not 100% sure about List::Utils, but believe it should both be BR'd and
Required:'ed

(IIUC, Sort-Maker-0.06/Sort/Maker.pm generates inlined code, which depends upon
List::Util)

* CONSIDER removing
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
(It's not needed in Fedora, anymore).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]