[Bug 1087988] Review Request: perl-Search-Elasticsearch - Official client for Elasticsearch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1087988

David Dick <ddick@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from David Dick <ddick@xxxxxxxx> ---
You've got a duplicate 

Requires:       perl(IO::Uncompress::Inflate)

line and you've missed

BR: perl(POSIX) # lib/Search/Elasticsearch/TestServer.pm at line 5
BR: perl(IO::Select) # lib/Search/Elasticsearch/Role/CxnPool.pm at line 6

As noted in the review above, you should probably put 

Requires:  perl(URI::Escape::XS)
Requires:  perl(JSON::XS)

in as well, as the rpm auto depends code does not detect them.

However, package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]