https://bugzilla.redhat.com/show_bug.cgi?id=1089770 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- SPEC: 1. %define name lxcf %define release 2 %define version 0.5 No please don't do that. It's just a waste of time, please use tags directly. 2. Prefix: %{_prefix} Group: Applications/Emulators Remove them, no need to keep them now. 3. In %build: make clean Why? 4. Since this package doesn't use configure, you should ensure that cflags(%{optflags}) and ldflags(%{__global_ldflags}) are set properly, currently I think it's not build correctly(conform to the Fedora guidelines). 5. parallel build https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make 6. %defattr(-,root,root) Remove it. 7. Try: rpm -E %{_sbindir} rpm -E %{_mandir} 8. %config(noreplace) %{_sysconfdir}/lxcf/lxcf.conf Unowned directory: %{_sysconfdir}/lxcf/ https://fedoraproject.org/wiki/Packaging:UnownedDirectories 9. %{_datadir}/doc/lxcf-%{version}/README %{_datadir}/doc/lxcf-%{version}/COPYING %{_datadir}/doc/lxcf-%{version}/ChangeLog %{_datadir}/doc/lxcf-%{version}/AUTHORS %{_datadir}/doc/lxcf-%{version}/example/README %{_datadir}/doc/lxcf-%{version}/example/HA10 %{_datadir}/doc/lxcf-%{version}/example/ops-script Since Fedora 20 the docdir is unversioned, please change. 10. Bad scriptlet syntax: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd ------------------------------- If you want to step furthur, you should follow https://fedoraproject.org/wiki/Join_the_package_collection_maintainers step by step. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review