[Bug 1086790] Review Request: gnudos - A GNU library to help new users of the GNU system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1086790



--- Comment #6 from Michael Schwendt <bugs.michael@xxxxxxx> ---
* https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


* fedora-review fails, and I couldn't find a new src.rpm:

  $ fedora-review -b 1086790
  INFO: Processing bugzilla bug: 1086790
  INFO: Getting .spec and .srpm Urls from : 1086790
  INFO:   --> SRPM url:
http://sites.google.com/site/mohammedisam2000/home/projects/gnudos-1.0-1.fc20.src.rpm
  ERROR: Cannot find usable urls here
  [...]

If you kept the "SRPM URL:" and "Spec URL:" lines in this ticket up-to-date and
accurate, you could point the fedora-review tool at this ticket.


> %post -p /sbin/ldconfig
> /sbin/install-info %{_infodir}/%{name}.info %{_infodir}/dir || :

That won't work and will cause an error during package installation/removal.
You cannot execute that scriptlet via /sbin/ldconfig. Option -p specifies the
scriptlet interpreter, which is /bin/sh by default. If you change it to
/sbin/ldconfig, the scriptlet body would need to be empty or executable by
ldconfig. Instead, you want to execute the scriptlet via /bin/sh:

  %post
  /sbin/ldconfig
  /sbin/install-info %{_infodir}/%{name}.info %{_infodir}/dir || :

Similarly for the %postun scriptlet.


> %files
> %{_libdir}/*

Still half-hearted, since obviously this includes everything in %_libdir, i.e.
also the files that belong only into the -devel subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]