https://bugzilla.redhat.com/show_bug.cgi?id=1089710 --- Comment #2 from Christian Dersch <chrisdersch@xxxxxxxxx> --- Review done! Looks fine, but please check perms of file /usr/lib64/python2.7/site-packages/gensim_addons/models/word2vec_inner.so Greetings, Christian Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 70 files have unknown license. Detailed output of licensecheck in /home/christian/1089710-python-gensim/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- gensim-addons , python-gensim-core , python-gensim-doc , python-gensim- test [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-gensim-addons-0.9.1-1.fc21.x86_64.rpm python-gensim-core-0.9.1-1.fc21.noarch.rpm python-gensim-doc-0.9.1-1.fc21.noarch.rpm python-gensim-test-0.9.1-1.fc21.noarch.rpm python-gensim-0.9.1-1.fc21.src.rpm python-gensim-addons.x86_64: W: spelling-error %description -l en_US modelling -> modeling, model ling, model-ling python-gensim-addons.x86_64: W: spelling-error %description -l en_US datastream -> data stream, data-stream, midstream python-gensim-addons.x86_64: W: no-documentation python-gensim-addons.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gensim_addons/models/word2vec_inner.so 0775L python-gensim-core.noarch: W: spelling-error %description -l en_US addons -> ad dons, ad-dons, adorns python-gensim-core.noarch: W: spelling-error %description -l en_US modelling -> modeling, model ling, model-ling python-gensim-core.noarch: W: spelling-error %description -l en_US datastream -> data stream, data-stream, midstream python-gensim-doc.noarch: W: doc-file-dependency /usr/share/doc/python-gensim-doc/examples/dmlcz/gensim_genmodel.py.addons /usr/bin/env python-gensim-doc.noarch: W: doc-file-dependency /usr/share/doc/python-gensim-doc/examples/dmlcz/gensim_xml.py.addons /usr/bin/env python-gensim-doc.noarch: W: doc-file-dependency /usr/share/doc/python-gensim-doc/examples/dmlcz/gensim_build.py.addons /usr/bin/env python-gensim-test.noarch: W: spelling-error Summary(en_US) Testsuite -> Test suite, Test-suite, Suite python-gensim-test.noarch: W: spelling-error %description -l en_US testsuite -> test suite, test-suite, suite python-gensim-test.noarch: W: no-documentation python-gensim.src: W: spelling-error %description -l en_US modelling -> modeling, model ling, model-ling python-gensim.src: W: spelling-error %description -l en_US datastream -> data stream, data-stream, midstream 5 packages and 0 specfiles checked; 1 errors, 14 warnings. ******** ==> Please check perms of file /usr/lib64/python2.7/site-packages/gensim_addons/models/word2vec_inner.so ******** Rpmlint (installed packages) ---------------------------- # rpmlint python-gensim-addons python-gensim-core python-gensim-doc python-gensim-test python-gensim-addons.x86_64: W: spelling-error %description -l en_US modelling -> modeling, model ling, model-ling python-gensim-addons.x86_64: W: spelling-error %description -l en_US datastream -> data stream, data-stream, midstream python-gensim-addons.x86_64: W: no-documentation python-gensim-addons.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gensim_addons/models/word2vec_inner.so 0775L python-gensim-core.noarch: W: spelling-error %description -l en_US addons -> ad dons, ad-dons, adorns python-gensim-core.noarch: W: spelling-error %description -l en_US modelling -> modeling, model ling, model-ling python-gensim-core.noarch: W: spelling-error %description -l en_US datastream -> data stream, data-stream, midstream python-gensim-doc.noarch: W: doc-file-dependency /usr/share/doc/python-gensim-doc/examples/dmlcz/gensim_genmodel.py.addons /usr/bin/env python-gensim-doc.noarch: W: doc-file-dependency /usr/share/doc/python-gensim-doc/examples/dmlcz/gensim_xml.py.addons /usr/bin/env python-gensim-doc.noarch: W: doc-file-dependency /usr/share/doc/python-gensim-doc/examples/dmlcz/gensim_build.py.addons /usr/bin/env python-gensim-test.noarch: W: spelling-error Summary(en_US) Testsuite -> Test suite, Test-suite, Suite python-gensim-test.noarch: W: spelling-error %description -l en_US testsuite -> test suite, test-suite, suite python-gensim-test.noarch: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 12 warnings. # echo 'rpmlint-done:' ******** ==> Please check perms of file /usr/lib64/python2.7/site-packages/gensim_addons/models/word2vec_inner.so ******** Requires -------- python-gensim-addons (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) numpy(x86-64) python(abi) python-gensim rtld(GNU_HASH) scipy(x86-64) python-gensim-core (rpmlib, GLIBC filtered): numpy python(abi) python-six scipy python-gensim-doc (rpmlib, GLIBC filtered): /usr/bin/env python-gensim-test (rpmlib, GLIBC filtered): python(abi) python-gensim python-gensim-addons python-nose Provides -------- python-gensim-addons: python-gensim-addons python-gensim-addons(x86-64) python-gensim-core: python-gensim python-gensim-core python-gensim-doc: python-gensim-doc python-gensim-test: python-gensim-test Unversioned so-files -------------------- python-gensim-addons: /usr/lib64/python2.7/site-packages/gensim_addons/models/word2vec_inner.so ******** ==> Should be ok for Python ******** Source checksums ---------------- https://github.com/piskvorky/gensim/archive/0.9.1.tar.gz#/python-gensim-0.9.1.tar.gz : CHECKSUM(SHA256) this package : 3303e24fb398ab180c569795696c900194a28d87da1cfca98358201dd238aba9 CHECKSUM(SHA256) upstream package : 3303e24fb398ab180c569795696c900194a28d87da1cfca98358201dd238aba9 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -b 1089710 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review