https://bugzilla.redhat.com/show_bug.cgi?id=1089559 --- Comment #3 from Christian Dersch <chrisdersch@xxxxxxxxx> --- Hi Jeremy! There are some issues with the package: 1.) Your package doesn't build in mock (please use it :), because the macros %{_presetdir} and %{_unitdir} are unknown. The macro definition is part of the systemd package, which should be a BuildRequires. Please add it! 2.) I'm not the author of the file 50-tlp.preset, maybe you got this information because I created the very first rpm for TLP (some years ago, for openSUSE, no systemd) ;) Other rpms were derived from this work. 3.) The sense of the preset file is enabling tlp automatically after installation? If yes: Please remove it, services should be enabled manually. Confirm https://fedoraproject.org/wiki/Packaging:Systemd#Why_don.27t_we.... 3.) Please order Requires (and BuildRequires) alphabetically About your questions: 1.) About TLP_NO_PMUTILS=1 I have to check later. I don't know the answer right now. 2.) CONFIG_ACPI_PROC_EVENT is not set http://pkgs.fedoraproject.org/cgit/kernel.git/tree/config-x86-generic#n89 3.) There is a macro for the udev rules, this is also part of the systemd package ;) It is called %{_udevrulesdir}, you can confirm the file /usr/lib/rpm/macros.d/macros.systemd for these macros After you made your corrections I will perform a more detailed review using the fedora-review tool. In general, fedora-review and mock are very powerful tools for packaging :) When I want to submit a new package, I always check that my package builds fine using mock. Then fedora-review works fine :) https://fedorahosted.org/FedoraReview/ https://fedoraproject.org/wiki/Projects/Mock Greetings, Christian -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review