https://bugzilla.redhat.com/show_bug.cgi?id=1084777 Shawn Iwinski <shawn.iwinski@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/pear/TheSeer(php- theseer-fDOMDocument, php-theseer-directoryscanner) Required pkg php-pear(%{pear_channel}/DirectoryScanner) already owns "%dir %{pear_phpdir}/TheSeer" This is a simple fix that can be done after initial import so I will not block acceptance because of this :) [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required As usual, just remove these after initial import. I had to disable the PHP fedora-review plugin because my phpcompatinfo (version 2.26.0) would get stuck in an infinite loop when calculating its' information. The requires look correct based on the actual script files and package.xml though. No blockers. ===== APPROVED ===== -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review