https://bugzilla.redhat.com/show_bug.cgi?id=1010741 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #39 from Christopher Meng <cickumqt@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find MIT-LICENSE.txt in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 55 files have unknown license. Detailed output of licensecheck: MIT/X11 (BSD like) ------------------ nikola-6.4.0/nikola/__init__.py nikola-6.4.0/nikola/__main__.py nikola-6.4.0/nikola/filters.py nikola-6.4.0/nikola/nikola.py nikola-6.4.0/nikola/plugin_categories.py nikola-6.4.0/nikola/plugins/basic_import.py nikola-6.4.0/nikola/plugins/command/__init__.py nikola-6.4.0/nikola/plugins/command/auto.py nikola-6.4.0/nikola/plugins/command/bootswatch_theme.py nikola-6.4.0/nikola/plugins/command/console.py nikola-6.4.0/nikola/plugins/command/deploy.py nikola-6.4.0/nikola/plugins/command/import_blogger.py nikola-6.4.0/nikola/plugins/command/import_feed.py nikola-6.4.0/nikola/plugins/command/import_wordpress.py nikola-6.4.0/nikola/plugins/command/init.py nikola-6.4.0/nikola/plugins/command/install_plugin.py nikola-6.4.0/nikola/plugins/command/install_theme.py nikola-6.4.0/nikola/plugins/command/new_page.py nikola-6.4.0/nikola/plugins/command/new_post.py nikola-6.4.0/nikola/plugins/command/planetoid/__init__.py nikola-6.4.0/nikola/plugins/command/serve.py nikola-6.4.0/nikola/plugins/command/version.py nikola-6.4.0/nikola/plugins/compile/__init__.py nikola-6.4.0/nikola/plugins/compile/asciidoc.py nikola-6.4.0/nikola/plugins/compile/bbcode.py nikola-6.4.0/nikola/plugins/compile/html.py nikola-6.4.0/nikola/plugins/compile/ipynb/__init__.py nikola-6.4.0/nikola/plugins/compile/markdown/__init__.py nikola-6.4.0/nikola/plugins/compile/markdown/mdx_gist.py nikola-6.4.0/nikola/plugins/compile/markdown/mdx_nikola.py nikola-6.4.0/nikola/plugins/compile/markdown/mdx_podcast.py nikola-6.4.0/nikola/plugins/compile/misaka.py nikola-6.4.0/nikola/plugins/compile/pandoc.py nikola-6.4.0/nikola/plugins/compile/php.py nikola-6.4.0/nikola/plugins/compile/rest/__init__.py nikola-6.4.0/nikola/plugins/compile/rest/chart.py nikola-6.4.0/nikola/plugins/compile/rest/doc.py nikola-6.4.0/nikola/plugins/compile/rest/listing.py nikola-6.4.0/nikola/plugins/compile/rest/media.py nikola-6.4.0/nikola/plugins/compile/rest/post_list.py nikola-6.4.0/nikola/plugins/compile/rest/slides.py nikola-6.4.0/nikola/plugins/compile/rest/vimeo.py nikola-6.4.0/nikola/plugins/compile/rest/youtube.py nikola-6.4.0/nikola/plugins/compile/textile.py nikola-6.4.0/nikola/plugins/compile/txt2tags.py nikola-6.4.0/nikola/plugins/compile/wiki.py nikola-6.4.0/nikola/plugins/loghandler/__init__.py nikola-6.4.0/nikola/plugins/loghandler/smtp.py nikola-6.4.0/nikola/plugins/loghandler/stderr.py nikola-6.4.0/nikola/plugins/task/__init__.py nikola-6.4.0/nikola/plugins/task/archive.py nikola-6.4.0/nikola/plugins/task/build_less.py nikola-6.4.0/nikola/plugins/task/build_sass.py nikola-6.4.0/nikola/plugins/task/bundles.py nikola-6.4.0/nikola/plugins/task/copy_assets.py nikola-6.4.0/nikola/plugins/task/copy_files.py nikola-6.4.0/nikola/plugins/task/galleries.py nikola-6.4.0/nikola/plugins/task/gzip.py nikola-6.4.0/nikola/plugins/task/indexes.py nikola-6.4.0/nikola/plugins/task/listings.py nikola-6.4.0/nikola/plugins/task/localsearch/__init__.py nikola-6.4.0/nikola/plugins/task/mustache/__init__.py nikola-6.4.0/nikola/plugins/task/pages.py nikola-6.4.0/nikola/plugins/task/posts.py nikola-6.4.0/nikola/plugins/task/redirect.py nikola-6.4.0/nikola/plugins/task/rss.py nikola-6.4.0/nikola/plugins/task/sitemap/__init__.py nikola-6.4.0/nikola/plugins/task/sources.py nikola-6.4.0/nikola/plugins/task/tags.py nikola-6.4.0/nikola/plugins/template/__init__.py nikola-6.4.0/nikola/plugins/template/jinja.py nikola-6.4.0/nikola/plugins/template/mako.py nikola-6.4.0/nikola/post.py nikola-6.4.0/nikola/rc4.py nikola-6.4.0/nikola/utils.py nikola-6.4.0/nikola/winutils.py nikola-6.4.0/setup.py nikola-6.4.0/tests/__init__.py Unknown or generated -------------------- nikola-6.4.0/docs/sphinx/conf.py nikola-6.4.0/dodo.py nikola-6.4.0/nikola/data/samplesite/listings/hello.py nikola-6.4.0/nikola/data/themes/base/messages/messages_bg.py nikola-6.4.0/nikola/data/themes/base/messages/messages_ca.py nikola-6.4.0/nikola/data/themes/base/messages/messages_cs.py nikola-6.4.0/nikola/data/themes/base/messages/messages_cz.py nikola-6.4.0/nikola/data/themes/base/messages/messages_de.py nikola-6.4.0/nikola/data/themes/base/messages/messages_el.py nikola-6.4.0/nikola/data/themes/base/messages/messages_en.py nikola-6.4.0/nikola/data/themes/base/messages/messages_eo.py nikola-6.4.0/nikola/data/themes/base/messages/messages_es.py nikola-6.4.0/nikola/data/themes/base/messages/messages_et.py nikola-6.4.0/nikola/data/themes/base/messages/messages_eu.py nikola-6.4.0/nikola/data/themes/base/messages/messages_fa.py nikola-6.4.0/nikola/data/themes/base/messages/messages_fi.py nikola-6.4.0/nikola/data/themes/base/messages/messages_fr.py nikola-6.4.0/nikola/data/themes/base/messages/messages_hi.py nikola-6.4.0/nikola/data/themes/base/messages/messages_hr.py nikola-6.4.0/nikola/data/themes/base/messages/messages_it.py nikola-6.4.0/nikola/data/themes/base/messages/messages_ja.py nikola-6.4.0/nikola/data/themes/base/messages/messages_nb.py nikola-6.4.0/nikola/data/themes/base/messages/messages_nl.py nikola-6.4.0/nikola/data/themes/base/messages/messages_pl.py nikola-6.4.0/nikola/data/themes/base/messages/messages_pt_br.py nikola-6.4.0/nikola/data/themes/base/messages/messages_ru.py nikola-6.4.0/nikola/data/themes/base/messages/messages_sl.py nikola-6.4.0/nikola/data/themes/base/messages/messages_sl_si.py nikola-6.4.0/nikola/data/themes/base/messages/messages_tr.py nikola-6.4.0/nikola/data/themes/base/messages/messages_tr_tr.py nikola-6.4.0/nikola/data/themes/base/messages/messages_ur.py nikola-6.4.0/nikola/data/themes/base/messages/messages_zh_cn.py nikola-6.4.0/nikola/plugins/__init__.py nikola-6.4.0/nikola/plugins/command/check.py nikola-6.4.0/nikola/plugins/command/mincss.py nikola-6.4.0/nikola/plugins/command/orphans.py nikola-6.4.0/nikola/plugins/compile/rest/gist.py nikola-6.4.0/nikola/plugins/compile/rest/soundcloud.py nikola-6.4.0/scripts/getpyver.py nikola-6.4.0/scripts/import_po.py nikola-6.4.0/scripts/set_version.py nikola-6.4.0/tests/base.py nikola-6.4.0/tests/data/translated_titles/conf.py nikola-6.4.0/tests/data/translated_titles/stories/1.txt.pl nikola-6.4.0/tests/import_wordpress_and_build_workflow.py nikola-6.4.0/tests/test_command_import_wordpress.py nikola-6.4.0/tests/test_command_init.py nikola-6.4.0/tests/test_compile_markdown.py nikola-6.4.0/tests/test_integration.py nikola-6.4.0/tests/test_locale.py nikola-6.4.0/tests/test_plugin_importing.py nikola-6.4.0/tests/test_rss_feeds.py nikola-6.4.0/tests/test_rst_compiler.py nikola-6.4.0/tests/test_scheduling.py nikola-6.4.0/tests/test_utils.py [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 12 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/getnikola/nikola/archive/v6.4.0.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- nikola-extras , python3-nikola , python3-nikola-extras , python-nikola- doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python-nikola-6.4.0-1.fc21.noarch.rpm python-nikola-extras-6.4.0-1.fc21.noarch.rpm python3-nikola-6.4.0-1.fc21.noarch.rpm python3-nikola-extras-6.4.0-1.fc21.noarch.rpm python-nikola-doc-6.4.0-1.fc21.noarch.rpm python-nikola-6.4.0-1.fc21.src.rpm python-nikola.noarch: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate python-nikola.noarch: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure python-nikola.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/nikola/data/themes/bootstrap3/assets/fonts /usr/share/fonts/glyphicons-halflings python-nikola.noarch: W: no-manual-page-for-binary nikola python3-nikola.noarch: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate python3-nikola.noarch: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure python3-nikola.noarch: W: dangling-symlink /usr/lib/python3.3/site-packages/nikola/data/themes/bootstrap3/assets/fonts /usr/share/fonts/glyphicons-halflings python3-nikola.noarch: W: no-manual-page-for-binary nikola3.3 python-nikola.src: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate python-nikola.src: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure python-nikola.src:101: W: mixed-use-of-spaces-and-tabs (spaces: line 101, tab: line 2) python-nikola.src: W: invalid-url Source0: https://github.com/getnikola/nikola/archive/v6.4.0.tar.gz <urlopen error _ssl.c:492: The handshake operation timed out> 6 packages and 0 specfiles checked; 0 errors, 12 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python3-nikola python-nikola-doc python-nikola-extras pyth on-nikola python3-nikola-extras python3-nikola.noarch: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate python3-nikola.noarch: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure python3-nikola.noarch: W: dangling-symlink /usr/lib/python3.3/site-packages/nikola/data/themes/bootstrap3/assets/fonts /usr/share/fonts/glyphicons-halflings python3-nikola.noarch: W: no-manual-page-for-binary nikola3.3 python-nikola.noarch: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate python-nikola.noarch: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure python-nikola.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/nikola/data/themes/bootstrap3/assets/fonts /usr/share/fonts/glyphicons-halflings python-nikola.noarch: W: no-manual-page-for-binary nikola 5 packages and 0 specfiles checked; 0 errors, 8 warnings. # echo 'rpmlint-done:' Requires -------- python3-nikola (rpmlib, GLIBC filtered): /usr/bin/python3 glyphicons-halflings-fonts python(abi) python3-PyRSS2Gen python3-blinker python3-colorama python3-docutils python3-doit python3-logbook python3-lxml python3-mako python3-pillow python3-pygments python3-pytz python3-unidecode python3-yapsy python-nikola-doc (rpmlib, GLIBC filtered): python-nikola-extras (rpmlib, GLIBC filtered): python-dateutil python-jinja2 python-markdown python-mock python-nikola python-pygal python-pyphen python-requests python-webassets python-nikola (rpmlib, GLIBC filtered): /usr/bin/python2 glyphicons-halflings-fonts python(abi) python-PyRSS2Gen python-blinker python-colorama python-docutils python-doit python-logbook python-lxml python-mako python-pillow python-pygments python-unidecode python-yapsy pytz python3-nikola-extras (rpmlib, GLIBC filtered): python3-dateutil python3-jinja2 python3-markdown python3-mock python3-nikola python3-pygal python3-pyphen python3-requests python3-webassets Provides -------- python3-nikola: python3-nikola python-nikola-doc: python-nikola-doc python-nikola-extras: python-nikola-extras python-nikola: python-nikola python3-nikola-extras: python3-nikola-extras Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn python-nikola-6.4.0-1.fc21.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ------------------------------------- Fix W: mixed-use-of-spaces-and-tabs (spaces: line 101, tab: line 2) before SCM. PACKAGE APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review