Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: freepops - POP3 interface to webmails https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233850 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-04-10 12:35 EST ------- Well, for -2: * Documention update - Update documents which uses /var/lib/freepops/. This fedora rpms use /usr/share/freepops. One example is doc/freepops-updater-dialog.1 . * Directory/file ownership - Well, as I noted above, while --------------------------------------- %files %dir foo/ --------------------------------------- means the directory foo/ only, whey you write --------------------------------------- foo/ --------------------------------------- it means the directory foo/ and all files/directories under foo/. So. --------------------------------------- %{_libdir}/freepops/ --------------------------------------- contains %{_libdir}/freepops/updater_fltk.so and this file is installed into main and -updater rpms. Also, %{_sysconfdir}/freepops/config.lua is listed twice. * Souce0 - Well, what I meant by "specify Source0 URL" is that you should write --------------------------------------- URL: http://www.freepops.org Source0: http://downloads.sourceforge.net/freepops/freepops-%{name}.tar.gz --------------------------------------- * Local copy of libraries - Check "Duplication of system libraries" of http://fedoraproject.org/wiki/Packaging/Guidelines . Here what is the problem is that this package (freepops) has a tarball of other libraries in it and use them, which must be avoided. You have to - first submit a review request of the libraries this package uses (luafilesystem, luacurl, luaexpat...) seperately - add patches to freepops so that freepops uses the _external_ libraries you submitted seperately. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review