https://bugzilla.redhat.com/show_bug.cgi?id=1084813 --- Comment #7 from Michael Schwendt <bugs.michael@xxxxxxx> --- Please keep the "SRPM URL:" and "Spec URL:" lines in this ticket up-to-date, so the fedora-review tool may be pointed at this ticket. The links to the src.rpm give 404 Not Found. The results from "fedora-review -b 1084813" would be interesting. You've missed a few issues from the earlier comment(s). So, some of these may be redundant: > Summary: Gnubatch provides enhanced job control In many many cases it is just bad form to repeat the program name in the %summary, especially when the package name is the same. Better and more concise would be to immediately start summing up what the package provides. For example: Summary: Enhanced job control system Summary: Comprehensive batch scheduling system The latter is from the first sentence of the %description. I'm not a fan of the "Enhanced" in the summary when the description doesn't expand on _what_ has been enhanced, and how. https://fedoraproject.org/wiki/Examples_of_good_package_summaries > #%setup -a 1 Be very careful with commenting out macros like that. Some macros are expanded and evaluated even then and may cause side-effects. Better replace the '%' with a '#' or '%%'. > %configure --sysconfdir=/etc/gnubatch --sharedstatedir=/var --localstatedir=/var --exec-prefix=/usr --prefix=/usr Why do you redefine several of the options? See output of "rpm -E %configure". > install -m 755 Prefer adding option "-p" to preserve timestamps when installing prebuilt files. https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps > %post > > echo "checking /etc/services setup for gnubatch" Scriptlets must not print anything deliberately. There's not even any guarantee that package install tools would show the output to the user. Only the scriptlet exit return code matters. > %attr(755,root,root) %{_bindir}/* > %attr(755,root,root) %{_libdir}/* > %attr(644,root,root) %{_unitdir}/* > %attr(755,root,root) /var/gnubatch Consider adjusting the file permissions in the buildroot with chmod (or via the supplied Makefiles, which you avoid because they seem unsuitable for installing into an empty buildroot). Overuse of %attr leads to problems occasionally and also raises the question whether/why you need to override default permissions. Prefer using %attr only for very special permissions you want to stick out in the spec file, e.g. setuid, setgid. The default for dirs is 0755,root,root and for files 0644,root,root already. > %attr(644,root,root) /usr/share/%{name}/help/* Either use %{_datadir} for /usr/share in all places, or hardcode /usr/share everywhere. Don't mix both forms: https://fedoraproject.org/wiki/Packaging:Guidelines#Macros > %attr(644,root,root) /usr/share/%{name}/help/* Directory /usr/share/gnubatch is not included. https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:UnownedDirectories -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review