[Bug 1089110] Review Request: nield - Network Interface Events Logging Daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1089110



--- Comment #2 from Christopher Meng <cickumqt@xxxxxxxxx> ---
SPEC file:

1. Packager: xxxx <txxx@xxxxxxxxx>

Remove that.

2. ExclusiveArch: %{ix86} x86_64

Why?

3. ${RPM_BUILD_ROOT}

Bad.

See
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

4. cp contrib/fedora/nield.service ${RPM_BUILD_ROOT}/%{_unitdir}

Use install -pm644 to do that.

5. %clean

Remove this section please.

6. %files
/usr/sbin/nield

/usr/sbin --> %{_sbindir}

7. %doc /usr/share/man/man8/nield.8.gz

No %doc for manpages please.

Also list manpages by:

%{_mandir}/man8/nield.8*

8. * Thu Apr 17 2014 t2mune - 0.5.0-1

Who are you? Name? Email address? I assume you are not a troll.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]