https://bugzilla.redhat.com/show_bug.cgi?id=1084654 Julien Enselme <jujens@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jujens@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |jujens@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Julien Enselme <jujens@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 81 files have unknown license. Detailed output of licensecheck in /home/jenselme/Downloads/tmp/1084654-python3-iep/licensecheck.txt [X]: Package must own all directories that it creates. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in python3-iep [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [X]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-iep-3.4-1.fc20.noarch.rpm python3-iep-3.4-1.fc20.src.rpm python3-iep.noarch: E: explicit-lib-dependency python3-pyzolib python3-iep.noarch: W: spelling-error %description -l en_US eep -> pee, rep, seep python3-iep.noarch: E: zero-length /usr/lib/python3.3/site-packages/iep/resources/style_solarizedlight.ssdf python3-iep.noarch: E: zero-length /usr/lib/python3.3/site-packages/iep/resources/style_scintilla.ssdf python3-iep.noarch: E: zero-length /usr/lib/python3.3/site-packages/iep/resources/style_solarizeddark.ssdf python3-iep.noarch: W: desktopfile-without-binary /usr/share/applications/iep.desktop /usr/bin/python3 python3-iep.src: W: spelling-error %description -l en_US eep -> pee, rep, seep 2 packages and 0 specfiles checked; 4 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python3-iep python3-iep.noarch: E: explicit-lib-dependency python3-pyzolib python3-iep.noarch: W: spelling-error %description -l en_US eep -> pee, rep, seep python3-iep.noarch: E: zero-length /usr/lib/python3.3/site-packages/iep/resources/style_solarizedlight.ssdf python3-iep.noarch: E: zero-length /usr/lib/python3.3/site-packages/iep/resources/style_scintilla.ssdf python3-iep.noarch: E: zero-length /usr/lib/python3.3/site-packages/iep/resources/style_solarizeddark.ssdf 1 packages and 0 specfiles checked; 4 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- python3-iep (rpmlib, GLIBC filtered): /bin/sh desktop-file-utils python(abi) python3-PyQt4 python3-pyzolib Provides -------- python3-iep: application() application(iep.desktop) python3-iep Source checksums ---------------- https://pypi.python.org/packages/source/i/iep/iep-3.4.tar.gz : CHECKSUM(SHA256) this package : b8376b28158d142ef324fe6c55e20a2108ed9108adf8137485711ed96d4ff8a3 CHECKSUM(SHA256) upstream package : b8376b28158d142ef324fe6c55e20a2108ed9108adf8137485711ed96d4ff8a3 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1084654 Buildroot used: fedora-20-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG I did the manual checkings. There is one problem: bundled fonts in resources/. They are already available in the official repos. Please add them as requirements. Fonts Guidelines: - https://fedoraproject.org/wiki/Packaging:Guidelines#Avoid_bundling_of_fonts_in_other_packages - https://fedoraproject.org/wiki/Packaging:FontsPolicy#Package_layout_for_fonts As for rpmlint: - python3-iep.noarch: E: explicit-lib-dependency python3-pyzolib: false positive, everything is fine - zero-lenght files: I do not see the purpose of these files. I used grep to search any occurence of them in the source code and I found none. I did not find any import of *.ssdf files either. I removed them and everything looked fine. I guess that you should ask upstream what is their use. - desktopfile-without-binary: there is an issue to change that: https://bitbucket.org/iep-project/iep/issue/288/pip-should-also-install-an-iep-startup I do not see this as blocking + should be fixed soon. Best regards, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review