https://bugzilla.redhat.com/show_bug.cgi?id=1088856 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-MouseX-Getopt.spec.old 2014-04-17 13:54:14.000000000 +0200 +++ perl-MouseX-Getopt.spec 2014-04-17 15:56:03.000000000 +0200 @@ -1,9 +1,11 @@ Name: perl-MouseX-Getopt Summary: Mouse role for processing command line options Version: 0.35 -Release: 1%{?dist} +Release: 2%{?dist} License: GPL+ or Artistic -URL: http://search.cpan.org/dist/MouseX-Getopt/ +# Hotfix release with different case, expected to revert to normal in subsequent releases +#URL: http://search.cpan.org/dist/MouseX-Getopt/ +URL: http://search.cpan.org/dist/mousex-getopt/ Source0: http://search.cpan.org/CPAN/authors/id/T/TO/TOKUHIROM/mousex-getopt-%{version}.tar.gz BuildArch: noarch # Module Build @@ -12,7 +14,7 @@ BuildRequires: perl(CPAN::Meta::Prereqs) BuildRequires: perl(File::Basename) BuildRequires: perl(File::Spec) -BuildRequires: perl(Module::Build) +BuildRequires: perl(Module::Build) >= 0.38 BuildRequires: perl(strict) BuildRequires: perl(utf8) BuildRequires: perl(warnings) @@ -21,10 +23,12 @@ BuildRequires: perl(Getopt::Long) >= 2.37 BuildRequires: perl(Getopt::Long::Descriptive) >= 0.081 BuildRequires: perl(Mouse) >= 0.64 +BuildRequires: perl(Mouse::Meta::Attribute) BuildRequires: perl(Mouse::Role) BuildRequires: perl(Mouse::Util::TypeConstraints) # Test Suite BuildRequires: perl(Mouse::Meta::Class) +BuildRequires: perl(Scalar::Util) BuildRequires: perl(Test::Exception) >= 0.21 BuildRequires: perl(Test::More) >= 0.88 BuildRequires: perl(Test::Mouse) @@ -37,6 +41,11 @@ %endif # Runtime Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) +Requires: perl(Mouse) >= 0.64 +Requires: perl(Mouse::Meta::Attribute) + +# Filter under-specified dependency +%global __requires_exclude ^perl\\(Mouse\\)$ %description This is a Mouse role that provides an alternate constructor for creating @@ -56,7 +65,9 @@ ./Build test %files -%doc Changes LICENSE README.md +# Note: malformed LICENSE file in 0.35 not shipped +# https://github.com/gfx/mousex-getopt/issues/2 +%doc Changes README.md %{perl_vendorlib}/MouseX/ %{_mandir}/man3/MouseX::Getopt.3* %{_mandir}/man3/MouseX::Getopt::Basic.3* @@ -70,6 +81,16 @@ %{_mandir}/man3/MouseX::Getopt::Strict.3* %changelog +* Thu Apr 17 2014 Paul Howarth <paul@xxxxxxxxxxxx> - 0.35-2 +- Incorporate feedback from package review (#1088856) + - Don't ship bogus LICENSE file + (https://github.com/gfx/mousex-getopt/issues/2) + - Make upstream URL refer to current release + - Upstream wants Module::Build ≥ 0.38 + - BR:/R: perl(Mouse::Meta::Attribute) + - BR: perl(Scalar::Util) for test suite + - R: perl(Mouse) ≥ 0.64 + * Thu Apr 17 2014 Paul Howarth <paul@xxxxxxxxxxxx> - 0.35-1 - Update to 0.35 - GLD 0.097 no longer defaults to no_ignore_case (CPAN RT#93593) > TODO: The LICENSE file content is wrong. I recommend either to add a comment > with a link to the upstream bug, or not to package the file. -%doc Changes LICENSE README.md +# Note: malformed LICENSE file in 0.35 not shipped +# https://github.com/gfx/mousex-getopt/issues/2 +%doc Changes README.md Ok. > FIX: Require `perl(Mouse::Meta::Attribute)' (lib/MouseX/Getopt/Meta/Attribute.pm:7). > FIX: Build-require `perl(Scalar::Util)' (t/003_inferred_option_type.t:17). +BuildRequires: perl(Mouse::Meta::Attribute) Ok. > TODO: Run-require versioned `perl(Mouse) >= 0.64'. > FIX: Run-require `perl(Mouse::Meta::Attribute)' (lib/MouseX/Getopt/Meta/Attribute.pm:7). $ rpm -q --requires -p ../RPMS/noarch/perl-MouseX-Getopt-0.35-2.fc21.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(Getopt::Long) >= 2.37 1 perl(Getopt::Long::Descriptive) >= 0.081 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Mouse) >= 0.64 1 perl(Mouse::Meta::Attribute) 1 perl(Mouse::Role) 1 perl(Mouse::Util::TypeConstraints) 1 perl(MouseX::Getopt::Meta::Attribute) 1 perl(MouseX::Getopt::Meta::Attribute::NoGetopt) 1 perl(MouseX::Getopt::OptionTypeMap) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Ok. $ rpmlint perl-MouseX-Getopt.spec ../SRPMS/perl-MouseX-Getopt-0.35-2.fc21.src.rpm ../RPMS/noarch/perl-MouseX-Getopt-0.35-2.fc21.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6749940). Ok. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review