https://bugzilla.redhat.com/show_bug.cgi?id=1088856 --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- The URL and Source0 is usable. Ok Notice: The URL points to the original CPAN package. Source archive is original (SHA-256: 5abe243a1ab05d64562358604de1d31d36994414c5c5eaeac688897129d2f9ae). Ok. Summary is Ok. Description verified from README. Ok. License verified from lib/MouseX/Getopt.pm, README.md. TODO: The LICENSE file content is wrong. I recommend either to add a comment with a link to the upstream bug, or not to package the file. No XS code, noarch BuildArch is Ok. Module::Build >= 0.38 is provided by all Fedoras (META.json:33). Unversioned `perl(Module::Build)' build-time dependency is Ok. FIX: Require `perl(Mouse::Meta::Attribute)' (lib/MouseX/Getopt/Meta/Attribute.pm:7). FIX: Build-require `perl(Scalar::Util)' (t/003_inferred_option_type.t:17). All tests pass. Ok. $ rpmlint perl-MouseX-Getopt.spec ../SRPMS/perl-MouseX-Getopt-0.35-1.fc21.src.rpm ../RPMS/noarch/perl-MouseX-Getopt-0.35-1.fc21.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-MouseX-Getopt-0.35-1.fc21.noarch.rpm drwxr-xr-x 2 root root 0 Apr 17 14:50 /usr/share/doc/perl-MouseX-Getopt -rw-r--r-- 1 root root 8957 Mar 10 08:02 /usr/share/doc/perl-MouseX-Getopt/Changes -rw-r--r-- 1 root root 36 Mar 10 08:02 /usr/share/doc/perl-MouseX-Getopt/LICENSE -rw-r--r-- 1 root root 8761 Mar 10 08:02 /usr/share/doc/perl-MouseX-Getopt/README.md -r--r--r-- 1 root root 4970 Apr 17 14:50 /usr/share/man/man3/MouseX::Getopt.3pm.gz -r--r--r-- 1 root root 2167 Apr 17 14:50 /usr/share/man/man3/MouseX::Getopt::Basic.3pm.gz -r--r--r-- 1 root root 2197 Apr 17 14:50 /usr/share/man/man3/MouseX::Getopt::Dashes.3pm.gz -r--r--r-- 1 root root 2029 Apr 17 14:50 /usr/share/man/man3/MouseX::Getopt::GLD.3pm.gz -r--r--r-- 1 root root 2488 Apr 17 14:50 /usr/share/man/man3/MouseX::Getopt::Meta::Attribute.3pm.gz -r--r--r-- 1 root root 2083 Apr 17 14:50 /usr/share/man/man3/MouseX::Getopt::Meta::Attribute::NoGetopt.3pm.gz -r--r--r-- 1 root root 2322 Apr 17 14:50 /usr/share/man/man3/MouseX::Getopt::Meta::Attribute::Trait.3pm.gz -r--r--r-- 1 root root 2105 Apr 17 14:50 /usr/share/man/man3/MouseX::Getopt::Meta::Attribute::Trait::NoGetopt.3pm.gz -r--r--r-- 1 root root 1973 Apr 17 14:50 /usr/share/man/man3/MouseX::Getopt::OptionTypeMap.3pm.gz -r--r--r-- 1 root root 1916 Apr 17 14:50 /usr/share/man/man3/MouseX::Getopt::Strict.3pm.gz drwxr-xr-x 2 root root 0 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX drwxr-xr-x 2 root root 0 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt -r--r--r-- 1 root root 8012 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt.pm -r--r--r-- 1 root root 7572 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt/Basic.pm -r--r--r-- 1 root root 1395 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt/Dashes.pm -r--r--r-- 1 root root 2377 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt/GLD.pm drwxr-xr-x 2 root root 0 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt/Meta drwxr-xr-x 2 root root 0 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt/Meta/Attribute -r--r--r-- 1 root root 2063 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt/Meta/Attribute.pm -r--r--r-- 1 root root 1015 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt/Meta/Attribute/NoGetopt.pm drwxr-xr-x 2 root root 0 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt/Meta/Attribute/Trait -r--r--r-- 1 root root 2117 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt/Meta/Attribute/Trait.pm -r--r--r-- 1 root root 942 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt/Meta/Attribute/Trait/NoGetopt.pm -r--r--r-- 1 root root 2263 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt/OptionTypeMap.pm -r--r--r-- 1 root root 578 Apr 17 14:50 /usr/share/perl5/vendor_perl/MouseX/Getopt/Strict.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-MouseX-Getopt-0.35-1.fc21.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(Getopt::Long) >= 2.37 1 perl(Getopt::Long::Descriptive) >= 0.081 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Mouse) 1 perl(Mouse::Role) 1 perl(Mouse::Util::TypeConstraints) 1 perl(MouseX::Getopt::Meta::Attribute) 1 perl(MouseX::Getopt::Meta::Attribute::NoGetopt) 1 perl(MouseX::Getopt::OptionTypeMap) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Run-require versioned `perl(Mouse) >= 0.64'. FIX: Run-require `perl(Mouse::Meta::Attribute)' (lib/MouseX/Getopt/Meta/Attribute.pm:7). $ rpm -q --provides -p ../RPMS/noarch/perl-MouseX-Getopt-0.35-1.fc21.noarch.rpm | sort | uniq -c 1 perl(MouseX::Getopt) 1 perl-MouseX-Getopt = 0.35-1.fc21 1 perl(MouseX::Getopt::Basic) 1 perl(MouseX::Getopt::Dashes) 1 perl(MouseX::Getopt::GLD) 1 perl(MouseX::Getopt::Meta::Attribute) 1 perl(MouseX::Getopt::Meta::Attribute::NoGetopt) 1 perl(MouseX::Getopt::Meta::Attribute::Trait) 1 perl(MouseX::Getopt::Meta::Attribute::Trait::NoGetopt) 1 perl(MouseX::Getopt::OptionTypeMap) 1 perl(MouseX::Getopt::Strict) Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-MouseX-Getopt-0.35-1.fc21.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6749437). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review