https://bugzilla.redhat.com/show_bug.cgi?id=1088277 Michal Fojtik <mfojtik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfojtik@xxxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Michal Fojtik <mfojtik@xxxxxxxxxx> --- Lubo: * I think the 'git' magic in %setup, can be replaced with a patch for the gemspec that provide a full list of files there (or replace it with "Dir['lib/*.rb'] + Dir['bin/*']" (but tbh I like the 'git init' hack as it seems less pain as maintaining the patch, why don't you include the 'bin' folder there as well? ;-) * there are no tests which will make QA unhappy, but they don't exists in upstream so OK by me. * everything else seems pretty sane to me, so review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review