https://bugzilla.redhat.com/show_bug.cgi?id=1087085 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Standalone spec file and the one embedded into SRPM package differ in changelog. I will use the standalone one which has newer time stamp. URL and Source0 are usable. Ok. Source archive is original (SHA-256: 45d19aef7e15d975bbe91b7fcd2f2aec650efd182654ed8b146e8b548a61d8f1). Ok. Summary verified from lib/POSIX/strftime/Compiler.pm. Ok. Description verified from lib/POSIX/strftime/Compiler.pm. Ok. TODO: "But this module will not affected by the system locale" description sentence is missing a predicate verb. I guess a "be" is missing there. Please correct the description. No XS code, noarch BuildArch is Ok. License verified from lib/POSIX/strftime/Compiler.pm, README.md, and LICENSE. Ok. TODO: You can remove the line deleting empty directories from %install section. Contemporary Module::Build does suffer from this bug. Time::TZOffset is optional (lib/POSIX/strftime/Compiler.pm:33,228). Ok. Module::Build >= 0.38 is provided by all Fedoras. Missing version constrain is Ok. Build-time dependencies are Ok. All tests pass. Ok. $ rpmlint perl-POSIX-strftime-Compiler.spec ../SRPMS/perl-POSIX-strftime-Compiler-0.31-1.fc21.src.rpm ../RPMS/noarch/perl-POSIX-strftime-Compiler-0.31-1.fc21.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-POSIX-strftime-Compiler-0.31-1.fc21.noarch.rpm drwxr-xr-x 2 root root 0 Apr 16 16:15 /usr/share/doc/perl-POSIX-strftime-Compiler -rw-r--r-- 1 root root 1095 Feb 24 07:27 /usr/share/doc/perl-POSIX-strftime-Compiler/Changes -rw-r--r-- 1 root root 18418 Feb 24 07:27 /usr/share/doc/perl-POSIX-strftime-Compiler/LICENSE -rw-r--r-- 1 root root 2656 Feb 24 07:27 /usr/share/doc/perl-POSIX-strftime-Compiler/README.md -rw-r--r-- 1 root root 3000 Apr 16 16:15 /usr/share/man/man3/POSIX::strftime::Compiler.3pm.gz drwxr-xr-x 2 root root 0 Apr 16 16:15 /usr/share/perl5/vendor_perl/POSIX drwxr-xr-x 2 root root 0 Apr 16 16:15 /usr/share/perl5/vendor_perl/POSIX/strftime -rw-r--r-- 1 root root 14866 Apr 16 16:15 /usr/share/perl5/vendor_perl/POSIX/strftime/Compiler.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-POSIX-strftime-Compiler-0.31-1.fc21.noarch.rpm | sort | uniq -c 1 perl >= 0:5.008004 1 perl(base) 1 perl(Carp) 1 perl(constant) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(POSIX) 1 perl(strict) 1 perl(Time::Local) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-POSIX-strftime-Compiler-0.31-1.fc21.noarch.rpm | sort | uniq -c 1 perl(POSIX::strftime::Compiler) = 0.31 1 perl-POSIX-strftime-Compiler = 0.31-1.fc21 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-POSIX-strftime-Compiler-0.31-1.fc21.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6746330). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review