https://bugzilla.redhat.com/show_bug.cgi?id=1081434 --- Comment #12 from Michael Schwendt <bugs.michael@xxxxxxx> --- Comments? Well, I'm not sure about the target group and usefulness of the library, if there's only a .bin pregenerated sample database. https://fedoraproject.org/wiki/Packaging:Guidelines#Packages_which_are_not_useful_without_external_bits That's why I focus on general packaging issues. * A newer rpmlint/rpmbuild (such as Fedora 20) reports: ip2location-c.src: E: specfile-error warning: bogus date in %changelog: Wed Apr 10 2014 Guruswamy Basavaiah <guru2018@xxxxxxxxx> 6.0.3-1 * Oddities in the x86_64 build.log: > checking size of long... 0 > checking size of off_t... 0 0? Running a koji scratch-build (or using "copr") and eliminating compiler warnings found in the build output is highly recommended. > /bin/sh ../libtool --tag=CC --mode=link gcc -IiMath/ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -lrt -module -no-undefined -version-info 1:0:0 -Wl,-z,relro -L/usr/lib -R/usr/lib -o libIP2Location.la -rpath /usr/lib64 libIP2Location_la-IP2Location.lo libIP2Location_la-IP2Loc_DBInterface.lo libIP2Location_la-imath.lo /usr/lib? libtool: link: DIE_RPATH_DIE="/usr/lib:" gcc -I../libIP2Location/iMath -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -Wl,-z -Wl,relro -o .libs/test-IP2Location test_IP2Location-test-IP2Location.o -L/usr/lib ../libIP2Location/.libs/libIP2Location.so -lrt /usr/lib? > i am working on the removal of dependency on the iMath source code. > With this removal of dependency, we don't need license clarification. ? Removing the bundled imath source code is one option. Packaging imath as a separate package might be another option. Requesting a bundling exception from the Fedora Packaging Committee (FPC) is another option. I'm not familiar with imath - is it a "copylib"? https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Copylibs The imath licensing terms give permission to merge the source code into another project (and the built binary library will be LGPLv3+ in this particular case, regardless of whether imath is built in), but they also ask for the copyright+license preamble to "be included in all copies or substantial portions of the Software", which complicates the licensing/relicensing and the tracking of modifications of the merged software (and what to do with its original licensing model when modifying it substantially). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review