https://bugzilla.redhat.com/show_bug.cgi?id=1087855 --- Comment #3 from Johan Swensson <kupo@xxxxxxx> --- (In reply to Christopher Meng from comment #2) > 1. LDFLAGS not set. > Fixed. > 2. mv scite/doc/scite.1 %{buildroot}%{_mandir}/man1/ > > Use install with -pm644 is better. > Fixed. > 3. It supports gtk3, please use gtk3. > Fixed, altough it still needs gtk2-devel to build. > 4. Why do we need ln -s SciTE %{buildroot}%{_bindir}/scite ? > The original package was called scite and not SciTE, I didn't change that. The upstream tarball is called sciteXXX.tgz too. It may also be because the man page is called scite.1 I guess the man page could be renamed if this is an issue. If this should be dropped I think the package should be renamed to SciTE as well, however other distros call it scite so I think it would be better to keep it all lowercase. > 5. desktop-file-install --vendor fedora --delete-original \ > > No vendor please. Fixed. Spec URL: http://opuk.fedorapeople.org/scite.spec SRPM URL: http://opuk.fedorapeople.org/SRPMS/scite-3.4.1-3.fc20.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6745226 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review