https://bugzilla.redhat.com/show_bug.cgi?id=1087893 --- Comment #5 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- Thanks for the review. I didn't have %prep and %build originally and as you say RPM worked fine. However rpmlint said ... ocaml-srpm-macros.spec: W: no-%prep-section The spec file does not contain a %prep section. Even if some packages don't directly need it, section markers may be overridden in rpm's configuration to provide additional "under the hood" functionality. Add the section, even if empty. ocaml-srpm-macros.spec: W: no-%build-section The spec file does not contain a %build section. Even if some packages don't directly need it, section markers may be overridden in rpm's configuration to provide additional "under the hood" functionality, such as injection of automatic -debuginfo subpackages. Add the section, even if empty. So I guess we need them, although I'm not sure I understand rpmlint's message. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review