https://bugzilla.redhat.com/show_bug.cgi?id=1087986 --- Comment #1 from David Dick <ddick@xxxxxxxx> --- Licensing is fine. FIX: BR: perl(Exporter) # line 10 of lib/Class/Forward TODO: Change the by author Source0 to a by module URL "Source0: http://www.cpan.org/modules/by-module/Class/Class-Forward-%{version}.tar.gz"; This will protect you if the author changes in the future. You can remove the "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;" line. It is not required except for EL5. You can update the "make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT" to "make pure_install DESTDIR=$RPM_BUILD_ROOT" reference can be found at https://fedoraproject.org/wiki/Perl/Tips?rd=PackagingTips/Perl#Makefile.PL_vs_Build.PL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review