https://bugzilla.redhat.com/show_bug.cgi?id=1084813 --- Comment #5 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. Summary: gnubatch provides enhanced job control Not good, uncapitalized. 2. Drop grop tag. 3. Drop BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) 4. Use %configure, currently the strip can't work properly and get these to users: ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-i386/root/', '--releasever', '21', 'install', '/home/rpmaker/Desktop/gnubatch/results/gnubatch-1.10-2.fc21.i686.rpm', '--setopt=tsflags=nocontexts'] Error: Package: gnubatch-1.10-2.fc21.i686 (/gnubatch-1.10-2.fc21.i686) Requires: libgnubatch_int.so.1.debug Error: Package: gnubatch-1.10-2.fc21.i686 (/gnubatch-1.10-2.fc21.i686) Requires: libgnubatch_curs.so.1.debug Error: Package: gnubatch-1.10-2.fc21.i686 (/gnubatch-1.10-2.fc21.i686) Requires: libgnubatch_client.so.1.debug You could try using --skip-broken to work around the problem Error: Package: gnubatch-1.10-2.fc21.i686 (/gnubatch-1.10-2.fc21.i686) Requires: libgnubatch_curs.so.debug Error: Package: gnubatch-1.10-2.fc21.i686 (/gnubatch-1.10-2.fc21.i686) Requires: libgnubatch_client.so.debug Error: Package: gnubatch-1.10-2.fc21.i686 (/gnubatch-1.10-2.fc21.i686) Requires: libgnubatch_int.so.debug You could try running: rpm -Va --nofiles --nodigest 5. rm -rf %{buildroot} 6. Executables should be set 755, others are 644, special files are custom. Therefore no 554/664/666 please. In order to not do this, please use install -pm$(PERMISSION) to install the relevant files to the correct dir in %install instead of cp. 7. /usr/share --> %{_datadir} 8. No need to %attr(664,root,root) in %config(noreplace) %attr(664,root,root) /etc/sysconfig/gnubatch.conf Remove that. 9. Scriptlet invalid, please don't use them. 10. Check and add missing syntax of systemd: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd 11. Source0: http://ftp.gnu.org/gnu/gnubatch/gnubatch-1.10.tar.gz Please use a macro at least for easier life: Source0: http://ftp.gnu.org/gnu/gnubatch/gnubatch-%{version}.tar.gz 12. Do we really need to gzip the systemd files? Why not provide them directly as SOURCE1, SOURCE2? 13. %{buildroot}/%{_unitdir} No slash after buildroot macro. 14. /etc --> %{_sysconfdir} 15. Why not use standard %make_install? If you find problem, patch them. 16. cp -p LICENSE %{buildroot}%{_defaultdocdir}/%{name}/ cp -p README %{buildroot}%{_defaultdocdir}/%{name}/ Dont do that! Use %doc macro in %files! 17. Please remove %clean section forever. 18. Leave a blank line between each changelog entry. 19. Please put %post and such sections before %files. 20. Drop %defattr(-,root,root,-) Hint, by using rpm -E $(MACROS), you can get the details of them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review