https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Offhand looks like a good start, some initial suggestions (SHOULD are just recommendations and/or a matter of taste, MUST are required): 1. SHOULD add Requires: hicolor-icon-theme instead of: %dir %{_datadir}/icons/hicolor %dir %{_datadir}/icons/hicolor/* 2. MUST add some icon scriptlets, see https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache 3. SHOULD include .spec comments clearly identifying items that are workarounds for the bugs referenced in comment #1 Oh, just noticed the bug is assigned, but no review flag set, Christopher, was that just an oversight? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review