Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jomolhari-fonts - Jomolhari a Bhutanese style font for Tibetan and Dzongkha https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231911 ------- Additional Comments From petersen@xxxxxxxxxx 2007-04-09 22:07 EST ------- Here is the review Good: + rpmlint outputs are clean + package name follows standard font package naming + spec file name follows package name + meets packaging guidelines + SIL OFL 1.0 is a recognised FOSS license + license file is included + spec file is legible and in English + md5sum matches upstream 0d03b98a7184a966815b85e7556e8bcb jomolhari-alpha003c.zip + package builds fine on fc6 i386 + no build deps + no translations + no libs + owns its directories + files list is good + clean section + consistent macro usage + package contains a free truetype font + no large documentation + no runtime %doc files + cleans buildroot before installing + package tested to work on upstream testpage Needs attention: - need to add "Requires(post)" and "Requires(postun)" for fontconfig (needed in tibetan-machine-uni-fonts too <blush/> and gentium-fonts...) Otherwise the package is fine. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review