[Bug 1086790] Review Request: gnudos - A GNU library to help new users of the GNU system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1086790



--- Comment #2 from Mohammed Isam <mohammed_isam1984@xxxxxxxxx> ---
(In reply to Michael Schwendt from comment #1)
> The packaging looks sloppy and half-hearted. :-(

Not intended to be so :-).. Fixing

> 
> > Summary:	The GnuDOS library for GNU/Linux
> > Group:		Applications/Productivity

Fixed

> 
> Library and headers in a single package? That's not how it is done with Red
> Hat and Fedora distributions:
> 
>   https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
> 
> 
> > %{_includedir}/console/*
> 

Fixed

> 
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#File_and_Directory_Ownership
> https://fedoraproject.org/wiki/Packaging:UnownedDirectories
> 
> 
> > %{_infodir}/*
> 
> https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo
> 

Added missing scriplets

> > $ rpmls -p gnudos-1.0-1.fc20.x86_64.rpm |grep ^d
> > drwxr-xr-x  /usr/share/doc/fog
> > drwxr-xr-x  /usr/share/doc/gnudos
> > drwxr-xr-x  /usr/share/doc/mino
> > drwxr-xr-x  /usr/share/doc/prime
> 
> Not directly a blocker, but it's not nice of an RPM package called "gnudos"
> to occupy the doc homedirs "fog", "mino" and "prime" just because it
> includes executables with the same names. Typically, the package
> documentation is included below %_docdir/%name (i.e. %_pkgdocdir for F20 and
> newer).
> 

Fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]