https://bugzilla.redhat.com/show_bug.cgi?id=949038 Shawn Iwinski <shawn.iwinski@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required As usual, just clean these up after initial import. [x]: Requires correct, justified where necessary. From package.xml: php-filter From phpcompatinfo: php-json Comment: # Optional but implicitly required # Horde_Db, Horde_Feed, Horde_Oauth, Horde_SyncMl but Horde_Feed is listed as required [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). php-horde-horde.noarch: E: incorrect-fsf-address /usr/share/doc/pear/horde/COPYING I am leaving it up to you to determine the "correctness" of the other rpmlint warnings/errors. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review